Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
SGX Launch Token (aka EINITTOKEN) is generated right-before Gramine launch via the
gramine-sgx-get-token
tool. For DCAP platforms, the SGX token is unused, so there is no need to generate it. This commit introduces a GSC switch--skip-token-generation
for this.This is useful for DCAP platforms (one less file in the Docker container), and enables such scenarios as
docker run --read-only
.Also, skipping running
gramine-sgx-get-token
paves a path to removing Python as a run-time dependency for GSC-built Docker images.Related PR in core Gramine: gramineproject/gramine#363
How to test this PR?
A Python example from docs with
./gsc build --skip-token-generation --insecure-args python test/generic.manifest
. You'll see thatgramine-sgx-get-token
tool is not called during the last step (docker run
).This change is