Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Update binaryen to version_109 #65

Merged
merged 6 commits into from
Aug 24, 2022
Merged

feat!: Update binaryen to version_109 #65

merged 6 commits into from
Aug 24, 2022

Conversation

phated
Copy link
Member

@phated phated commented Aug 24, 2022

Mostly update binaryen, but added a few more changes I've been meaning to do.

We should figure out when we want to drop dune 2.x support soon.

@phated phated requested a review from ospencer August 24, 2022 00:29
@phated
Copy link
Member Author

phated commented Aug 24, 2022

Dune 3.4+ is broken in esy + Windows (ref ocaml/dune#6098) so I've restricted it

Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@phated phated merged commit f79c848 into main Aug 24, 2022
@phated phated deleted the phated/109 branch August 24, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants