Skip to content

Commit

Permalink
feat!: Upgrade binaryen to version_105 (#46)
Browse files Browse the repository at this point in the history
feat: Remove unnecessary conf-python-3 dependency
  • Loading branch information
phated authored Mar 4, 2022
1 parent dd5bf7e commit e1d386e
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 11 deletions.
1 change: 0 additions & 1 deletion .github/workflows/opam.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ jobs:

- name: Inspect depexts
run: |
opam exec -- which python
opam exec -- which cmake
- name: Install local dependencies
Expand Down
8 changes: 0 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,6 @@ Inside your dune file, you can depend on `libbinaryen` as such:
(flags :standard -O2 -Wall -Wextra)))
```

## Dependencies

This project requires `CMake` and `python` (v3.5 or greater).

When installing with opam, both of these dependencies will be checked using `conf-cmake` and `conf-python-3`.

When installing with esy, CMake will be built from source, and, on Mac or Linux, Python must be globally installed within a location that esy knows about (those being `/usr/local/bin`, `/usr/bin`, `/bin`, `/usr/sbin`, or `/sbin`). On Windows, a suitable python is already available from esy-bash.

## MacOS C++ Compiler

When including this library in your `dune` MacOS executables, you'll need to specify `-cc clang++` in your `(flags)` stanza. This is required because Binaryen will throw errors for itself to catch and using `clang++` is the only way to handle them correctly. You can find more info on this [ocaml issue](https://github.com/ocaml/ocaml/issues/10423).
Expand Down
2 changes: 1 addition & 1 deletion binaryen
Submodule binaryen updated 170 files
1 change: 0 additions & 1 deletion libbinaryen.opam
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ build: [
]
depends: [
"conf-cmake" {build}
"conf-python-3" {build}
"dune" {>= "2.9.1"}
"dune-configurator" {>= "2.9.1"}
"ocaml" {>= "4.12"}
Expand Down

0 comments on commit e1d386e

Please sign in to comment.