feat!: Remove -> token in favor of =>
#2177
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
requested review from
ospencer,
peblair,
phated,
marcusroberts,
alex-snezhko and
jozanza
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
->support in the compiler as we said we were only going to keep it throughv0.6, This is my first change to the parser that changes the way tokens are evaluated, I went through and manually updated theparsers.messagesfile I dont know if I was meant todo it another way but menhir seemed fine with it :).One thing I was wondering is maybe instead of fully removing support for
->do we want to still handle lexing it and throw an error in the lexer about it being deprecated for a few versions? I think this behaviour is desirable over the formatter approach as it signifies we dont support the syntax but makes it clear why things broke.Breaking as we are removing support for
->