Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 43: email i18n files #86

Merged
merged 11 commits into from
Dec 5, 2017
Merged

Issue 43: email i18n files #86

merged 11 commits into from
Dec 5, 2017

Conversation

ddelponte
Copy link
Collaborator

@ddelponte ddelponte commented Nov 28, 2017

• Modified forgot password email to be internationalized by now rendering it with a gsp that utilizes `messages.properties`
• modified email from config text to be more friendly.  It is now 'Do Not Reply <do.not.reply@localhost>'
• modified subject line retrieval to pass an array to `getMessage` instead of a List
• fixed bug where html was being escaped in email body
• sending of verification email using gsps has been implemented
• for backwards compatibility, if the user has overridden the body in the config, the text from the config will be used in registration email
• modified forgot password email logic to support using the email body as defined in the config it it exists, otherwise it will use gsps
• fixed broken tests
• added a test that verifies the registration email subject will be loaded first from `DefaultUiSecurityConfig` and, if it doesn't exist in config, then it will be loaded from `messages.properties`.
• implemented loading of forgot password email subject from config if it exists (for legacy support) else it will load from `messages.properties`
• wrote a test

This will resolve issue #43

• Modified forgot password email to be internationalized by now rendering it with a gsp that utilizes `messages.properties`
• modified email from config text to be more friendly.  It is now 'Do Not Reply <do.not.reply@localhost>'
• modified subject line retrieval to pass an array to `getMessage` instead of a List
• fixed bug where html was being escaped in email body
• sending of verification email using gsps has been implemented
• for backwards compatibility, if the user has overridden the body in the config, the text from the config will be used in registration email
• modified forgot password email logic to support using the email body as defined in the config it it exists, otherwise it will use gsps
• fixed broken tests
…ded first from `DefaultUiSecurityConfig` and, if it doesn't exist in config, then it will be loaded from `messages.properties`.

this was done to ensure backwards compatibility
… it exists (for legacy support) else it will load from `messages.properties`

• wrote a test
… it exists (for legacy support) else it will load from `messages.properties`

• wrote a test
…when a type of `register` is targeted

• modified documentation to reflect the additional templates and layout now beign copied when targeting `register` override
@sdelamo sdelamo self-assigned this Dec 5, 2017
@sdelamo sdelamo merged commit 9fdd01e into master Dec 5, 2017
@sdelamo sdelamo deleted the issue-43 branch December 5, 2017 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants