Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor UserController as demonstrated in PR 13 #79

Closed
ddelponte opened this issue Oct 4, 2017 · 1 comment
Closed

Refactor UserController as demonstrated in PR 13 #79

ddelponte opened this issue Oct 4, 2017 · 1 comment
Assignees
@ddelponte
Labels
Improvement In Code Review In Progress

Comments

@ddelponte
Copy link
Collaborator

ddelponte commented Oct 4, 2017 •
edited
Loading

PR #13 is an old PR that provided a nice refactoring of some logic in the UserController but now has conflicts.

The purpose of this issue is to:

  1. request a new PR be created which applies the original refactoring
  2. a test be created
  3. the old PR be closed
@ddelponte ddelponte self-assigned this Oct 4, 2017
ddelponte added a commit that referenced this issue Oct 4, 2017
@ddelponte
Issue #79: Refactor UserController as demonstrated in PR 13
341c1f7 
This is step one of the refactoring which:
1. pulls the existing code used to build the `roleMap` out into its own, testable method
2. implements a test to verify existing functionality
ddelponte added a commit that referenced this issue Oct 4, 2017
@ddelponte
Issue #79: Refactor UserController as demonstrated in PR 13
fccf262 
Applied refactoring from PR #13
This was referenced Oct 4, 2017
Merged
Closed
sdelamo pushed a commit that referenced this issue Oct 19, 2017
@ddelponte @sdelamo
Issue #79: Refactor UserController as demonstrated in PR 13
d35939f 
This is step one of the refactoring which:
1. pulls the existing code used to build the `roleMap` out into its own, testable method
2. implements a test to verify existing functionality
sdelamo pushed a commit that referenced this issue Oct 19, 2017
@ddelponte @sdelamo
Issue #79: Refactor UserController as demonstrated in PR 13
a6f4517 
Applied refactoring from PR #13
@ddelponte
Copy link
Collaborator Author

Closing. This has been resolved by PR #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddelponte ddelponte

Labels
Improvement In Code Review In Progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ddelponte