Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin update for grails version 6.1.1 and jdk 11 #120

Closed
wants to merge 3 commits into from
Closed

Plugin update for grails version 6.1.1 and jdk 11 #120

wants to merge 3 commits into from

Conversation

fernando88to
Copy link
Contributor

@fernando88to fernando88to commented Dec 25, 2023

Tasks that were done

  • This pull request presents a comprehensive refactoring of our plugin's unit tests, with the aim of ensuring full compatibility with the latest version of Grails.

  • Plugin update for grails version 6.1.1 and jdk 11

  • Create command for create-job

  • update documentation

Steps that remain to be taken

  • Generate documentation
  • Configure application publication

@fernando88to fernando88to changed the title Refactor unit tests to Spock framework Plugin update for grails version 6.1.1 and jdk 11 Dec 26, 2023
@puneetbehl puneetbehl changed the base branch from master to 2.0.x January 16, 2024 10:44
@puneetbehl puneetbehl changed the base branch from 2.0.x to 3.0.x January 16, 2024 11:31
@puneetbehl
Copy link
Contributor

@Richardson-e Could you please review this pull-request?

@dauer
Copy link

dauer commented Jan 24, 2024

I ran into an issue with the 2.0.13 version of the Quartz plugin when upgrading from Grails 4.1.1 -> 6.1.1, so I tried building a local version from @fernando88to branch and that fixed my failing tests - so it looks very promising!

Only thing is that when doing a gradle publishToMavenLocal the jar file had -plain added to the filename:
quartz-2.0.14.BUILD-SNAPSHOT-plain.jar
Expecting:
quartz-2.0.14.BUILD-SNAPSHOT.jar

@CLAassistant
Copy link

CLAassistant commented Mar 26, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@puneetbehl
Copy link
Contributor

@matrei Can you please look into this?

@matrei
Copy link
Contributor

matrei commented Mar 28, 2024

@matrei Can you please look into this?

@puneetbehl There is some overlap with #125.
@fernando88to Good with a rewrite of the tests to spock 👍 .
Can you create a new PR based on 3.0.x with only those?

@fernando88to
Copy link
Contributor Author

@matrei Can you please look into this?

@puneetbehl There is some overlap with #125. @fernando88to Good with a rewrite of the tests to spock 👍 . Can you create a new PR based on 3.0.x with only those?

I am going to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants