-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compile grails-gradle-plugin with the Groovy version provided by Gradle #334
compile grails-gradle-plugin with the Groovy version provided by Gradle #334
Conversation
to ensure build compatibility with Gradle, currently Groovy 3.0.x see: https://docs.gradle.org/current/userguide/compatibility.html#groovy
Is this a safe-guard for future changes to the build? ./gradlew dI --dependency groovy --configuration compileClasspath
> Task :dependencyInsight
No dependencies matching given input were found in configuration ':compileClasspath'
These however, do have Groovy 4 on the // resolve conflict from Gradle's version of Groovy. Not needed if Gradle switches to 4.0
configurations.configureEach { exclude group: 'org.apache.groovy' }
|
Yes, this change plus similar compile changes on Recent changes to grails-gradle-plugin had us move to groovy 4 and then back to 3. The need to ensure Groovy 3 is used to compile was illustrated by the asset-pipeline-gradle:5.0.0 release and it seemed like a good idea to do the same in Grails. |
to ensure build compatibility with Gradle, currently Groovy 3.0.x see: https://docs.gradle.org/current/userguide/compatibility.html#groovy
f801917
to
e384def
Compare
to ensure build compatibility with Gradle, currently Groovy 3.0.x see: https://docs.gradle.org/current/userguide/compatibility.html#groovy
This will prevent running into Groovy 4 vs 3 compatibility issues like: bertramdev/asset-pipeline#350, when Gradle executes the build using it's embedded Groovy Version, currently 3.0.22.
This will also be done on
grails-gradle-model
,grails-shell
andgrails-bootstrap
ingrails-core
. grails/grails-core#13653Move all versions numbers to gradle.properties and update dependencies to latest compatible version
Simplify
ext."signing.*"