Skip to content

Commit

Permalink
fix(deps): Remove dependency org.hibernate:hibernate-core (#286)
Browse files Browse the repository at this point in the history
There is no need to include this library as a direct dependency for Grails applications.
Any libraries/modules that depend on it declares it themselves.
  • Loading branch information
matrei authored Mar 9, 2024
1 parent 6b8d702 commit 1a3d287
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,6 @@ public void apply(GeneratorContext generatorContext) {
.groupId("org.grails.plugins")
.artifactId("hibernate5")
.compile());
generatorContext.addDependency(Dependency.builder()
.groupId("org.hibernate")
.lookupArtifactId("hibernate-core")
.compile());
generatorContext.addDependency(Dependency.builder()
.groupId("org.glassfish.web")
.lookupArtifactId("el-impl")
Expand Down
5 changes: 0 additions & 5 deletions grails-forge-core/src/main/resources/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,6 @@
</repository>
</repositories>
<dependencies>
<dependency>
<groupId>org.hibernate</groupId>
<artifactId>hibernate-core</artifactId>
<version>5.6.15.Final</version>
</dependency>
<dependency>
<groupId>org.glassfish.web</groupId>
<artifactId>el-impl</artifactId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ class HibernateGormSpec extends ApplicationContextSpec implements CommandOutputF

then:
template.contains('implementation("org.grails.plugins:hibernate5")')
template.contains('implementation("org.hibernate:hibernate-core:5.6.15.Final")')
template.contains("runtimeOnly(\"org.glassfish.web:el-impl:2.2.1-b05\")")
template.contains("runtimeOnly(\"org.apache.tomcat:tomcat-jdbc\")")
template.contains("runtimeOnly(\"com.h2database:h2\")")
Expand Down

0 comments on commit 1a3d287

Please sign in to comment.