Ensured re-rendering the stack uses the latest scene and props #637
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #635
Was using
let { current: allScenes } = useRef
but this created a stale closure. It meant theNavigationStack
didn't get the latest scene and props from its children. For example, conditional navigation, where dynamically configure the stack of scenes, didn't work. Changing to constconst allScenes = useRef
fixed it.But noticed another problem where
allScenes
was a tempo behind because it was updated inuseEffect
. So it would take an additional render forNavigationStack
to have the latest scenes and props. For example, this wouldn't render 'true'.Changed
allScenes
fromref
toconst
and built it during render instead of waiting foruseEffect
.Strangely the same code in
NavigationMotion
didn't have the stale closure. Well, it was stale but by the timerenderScene
happened it had the latest scenes and props. But updatedNavigationMotion
to ensure it never has a stale closure.