Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(perf): remove imports that bloat bundle #1215

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

jasonkuhrt
Copy link
Member

@jasonkuhrt jasonkuhrt commented Oct 24, 2024

Progresses #1216

The primary changes here:

  1. Redefine Kind and OperationTypeNode enums from GraphQL in a tree-shakable way.

Before (~5000b):

CleanShot 2024-10-24 at 16 03 06@2x

After (~850b):

CleanShot 2024-10-24 at 16 06 20@2x

  1. Avoid references to GraphQLError. It drags in a lot of the graphql package.

@jasonkuhrt jasonkuhrt merged commit 54d048e into main Oct 24, 2024
13 checks passed
@jasonkuhrt jasonkuhrt deleted the feat/remove-imports-that-implicate-graphql-kb branch October 24, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant