Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete verification operations in attestation package #526

Merged
merged 4 commits into from
Jun 10, 2020
Merged

Delete verification operations in attestation package #526

merged 4 commits into from
Jun 10, 2020

Conversation

acamadeo
Copy link
Contributor

@acamadeo acamadeo commented Jun 5, 2020 •
edited
Loading

Delete unused verification operations in Kritis's attestation package. Kritis has migrated to cryptolib for this functionality.

@acamadeo acamadeo requested review from nenaddedic and ooq June 5, 2020 14:41
ooq
ooq approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@ooq ooq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pull-request-size pull-request-size bot added size/M and removed size/L labels Jun 10, 2020
@acamadeo
Copy link
Contributor Author

Local integration tests passed.

@acamadeo acamadeo merged commit 537f5e9 into grafeas:master Jun 10, 2020
@acamadeo acamadeo mentioned this pull request Jun 12, 2020
Open
10 tasks
@acamadeo acamadeo deleted the delete-old-attestation-funcs branch June 23, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nenaddedic nenaddedic nenaddedic approved these changes

@ooq ooq ooq approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acamadeo @ooq @nenaddedic