Replace RawAttestation with Cryptolib Attestation #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate metadata_test and cache_test Migrate grafeas.go Update most tests in review package Remove tests for generic and unknown signature types [ISSUE-506] Remove unnecessary error check Leftover from grafeas#511. Also see the discussion [here](grafeas#514 (comment)). Disclaimer: I was not able to test this locally now, but reading the code and the aforementioned PR, I believe this change is correct. Cleanup base64 Clean up comments Modify helpers Last revisions
alexcope
reviewed
May 29, 2020
|
Feel free to ignore the cloud build error for now. |
ooq
approved these changes
Jun 1, 2020
nenaddedic
reviewed
Jun 3, 2020
| } | ||
| ras = append(ras, ra) | ||
| atts = append(atts, att) |
There was a problem hiding this comment.
I suggest returning []cryptolib.Attestation{att} directly. Also below.
| func (avt *AttestorValidatingTransport) fetchAttestations(image string) ([]*cryptolib.Attestation, error) { | ||
| atts := []*cryptolib.Attestation{} | ||
| rawAtts, err := avt.Client.Attestations(image, &avt.Attestor) | ||
| func (avt *AttestorValidatingTransport) fetchAttestations(image string) ([]cryptolib.Attestation, error) { |
There was a problem hiding this comment.
In L154, you can just call avt.Client.Attestations directly and get rid of fetchAttestations() altogether.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace all instances of
RawAttestationwith cryptolibAttestation. Includes documentation fixes for functions and structs.