-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base64 signature #429
Base64 signature #429
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments about severity of logging and a nit on fn naming.
@nenaddedic: before merging, could you please confirm integration tests pass locally for you? The kokoro results look like a flake, but I'd like to confirm first. |
@aysylu yes, they pass locally |
This is a fix for #427.
Changes:
This change breaks backwards compatibility. Attestations verifiable with old code are no longer verifiable with the new code.
Users of GAP will have to recreate the attestations.
Effects on ISP will be limited: attestations previously created by ISP will become invalid, but ISP will create new valid ones for images passing the ISP. The only tricky case is that of a deployment previously passing the ISP (under the old code), but which is now not passing. In this case, new Pods will trigger ISP re-evaluation (because invalid attestations, under the new code), which will fail.