Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use re-usable workflow #54

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Use re-usable workflow #54

merged 3 commits into from
Aug 24, 2023

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Aug 22, 2023 •
edited
Loading

What?

Using the common CI workflow form the k6-ci.

Why?

That way, the same standards apply to the repository code, and we also have less maintenance costs.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make test) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@olegbespalov olegbespalov requested a review from a team as a code owner August 22, 2023 09:05
@olegbespalov olegbespalov requested review from oleiade and codebien and removed request for a team August 22, 2023 09:05
@olegbespalov olegbespalov self-assigned this Aug 22, 2023
codebien
codebien reviewed Aug 22, 2023
View reviewed changes
Copy link
Contributor

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mostly waiting for a green CI

@olegbespalov olegbespalov mentioned this pull request Aug 24, 2023
Open
@olegbespalov olegbespalov requested a review from codebien August 24, 2023 11:37
@olegbespalov
Copy link
Contributor Author

@codebien The cause of why CI is failing is definitely not related to the PR 😢 I made a minor adjustment which 9dee277 makes the CI green and not block actual merge of standardization, but it worth to investigate the root cause separately (in #55). Hope that works

@olegbespalov olegbespalov merged commit ec8e44a into main Aug 24, 2023
@olegbespalov olegbespalov deleted the feat/common-ci branch August 24, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebien codebien codebien approved these changes

@oleiade oleiade oleiade approved these changes

Assignees

@olegbespalov olegbespalov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olegbespalov @oleiade @codebien