Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify, format, and run tests against examples #77

Merged
merged 5 commits into from
Apr 23, 2024

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Apr 18, 2024

What?

Note that: import/export examples are commented on since they are actually catch a data race that should be resolved after #76

Sorry for the big PR. It's better to check by commit; the first commit could be skipped since it's auto-formating.

Why?

Unifying examples should improve the documentation and simplify their maintenance.

A pull-request starter #67 (comment)

Running the tests against examples should help with finding degradations like #68

@olegbespalov olegbespalov changed the title Chore/format examples Unify and format examples Apr 18, 2024
@olegbespalov olegbespalov mentioned this pull request Apr 18, 2024
@olegbespalov olegbespalov force-pushed the chore/format-examples branch 2 times, most recently from 4298568 to 806d97e Compare April 18, 2024 15:01
@olegbespalov olegbespalov marked this pull request as ready for review April 18, 2024 15:02
@olegbespalov olegbespalov requested a review from a team as a code owner April 18, 2024 15:02
@olegbespalov olegbespalov requested review from mstoykov and joanlopez and removed request for a team April 18, 2024 15:02
@olegbespalov olegbespalov changed the title Unify and format examples Unify, format, and run tests against examples Apr 18, 2024
@olegbespalov olegbespalov self-assigned this Apr 18, 2024
@olegbespalov olegbespalov force-pushed the chore/format-examples branch from 806d97e to 2fa761d Compare April 19, 2024 10:53
@olegbespalov olegbespalov requested a review from mstoykov April 19, 2024 10:54
@olegbespalov olegbespalov force-pushed the chore/format-examples branch from 2fa761d to 57e9fb6 Compare April 19, 2024 11:07
@olegbespalov olegbespalov force-pushed the chore/format-examples branch from 57e9fb6 to 0bf8c97 Compare April 22, 2024 08:15
@olegbespalov
Copy link
Contributor Author

olegbespalov commented Apr 22, 2024

@mstoykov FYI, after including import/export (data race has gone with #76 ), I've found that one of the examples become broken (:tada:) and I include a minor fix 445ad03 to this PR. Hope that works!

@olegbespalov
Copy link
Contributor Author

@joanlopez Since this PR is mostly about auto-applying the eslint + moving things around, I'm going to merge it as it is (since I need a couple more based on it). If you have any other feedback, feel free to bring it, and I'll iterate on it separately with PRs if needed.

@olegbespalov olegbespalov merged commit 695232b into main Apr 23, 2024
10 checks passed
@olegbespalov olegbespalov deleted the chore/format-examples branch April 23, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants