Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address linter issues related to repeated static strings #58

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Address linter issues related to repeated static strings #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions webcrypto/aes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ func exportAESKey(key *CryptoKey, format KeyFormat) ([]byte, error) {
return handle, nil
default:
// FIXME: note that we do not support JWK format, yet.
return nil, NewError(NotSupportedError, "unsupported key format "+format)
return nil, NewError(NotSupportedError, unsupportedKeyFormatErrorMsg+" "+format)
}
}

Expand Down Expand Up @@ -184,7 +184,7 @@ func (aip *AESImportParams) ImportKey(
return nil, NewError(DataError, "invalid key length")
}
default:
return nil, NewError(NotSupportedError, "unsupported key format "+format)
return nil, NewError(NotSupportedError, unsupportedKeyFormatErrorMsg+" "+format)
}

key := &CryptoKey{
Expand Down Expand Up @@ -629,3 +629,9 @@ func pKCS7Pad(plaintext []byte, blockSize int) ([]byte, error) {
paddingText := bytes.Repeat([]byte{byte(padding)}, padding)
return append(plaintext, paddingText...), nil
}

// unsupportedKeyFormatErrorMsg is the error message returned when an unsupported
// key format is passed to a function.
//
// This is defined as a constant to cater to linter warnings.
const unsupportedKeyFormatErrorMsg = "unsupported key format"