Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor naming to follow Go naming conventions #46

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Conversation

oleiade
Copy link
Member

@oleiade oleiade commented Apr 14, 2023

This PR renames most structs and constants involving an acronym or cipher name following the Go convention of holding to acronyms as capitalised strings.

closes #39

@oleiade oleiade added the enhancement New feature or request label Apr 14, 2023
@oleiade oleiade requested review from mstoykov and codebien April 14, 2023 12:35
@oleiade oleiade self-assigned this Apr 14, 2023
Copy link

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a comment regarding the combined acronyms.

webcrypto/aes.go Outdated Show resolved Hide resolved
@oleiade oleiade merged commit be1e251 into main Apr 19, 2023
@oleiade oleiade deleted the refactor/naming branch April 19, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make naming consistent throughout the codebase
3 participants