Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New format for custom HTTP headers #147

Merged
merged 2 commits into from
Sep 25, 2023
Merged

New format for custom HTTP headers #147

merged 2 commits into from
Sep 25, 2023

Conversation

codebien
Copy link
Contributor

@codebien codebien commented Sep 22, 2023 •
edited
Loading

Closes #101

@codebien codebien self-assigned this Sep 22, 2023
@codebien codebien changed the base branch from migrate-to-klaus-snappy to main September 22, 2023 15:04
@codebien codebien marked this pull request as ready for review September 22, 2023 15:26
@codebien codebien requested a review from a team as a code owner September 22, 2023 15:26
@codebien codebien requested review from mstoykov and olegbespalov and removed request for a team September 22, 2023 15:26
olegbespalov
olegbespalov reviewed Sep 22, 2023
View reviewed changes
Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left a two minor discussable comments

pkg/remotewrite/config.go Outdated Show resolved Hide resolved
pkg/remotewrite/config.go Outdated Show resolved Hide resolved
@codebien codebien force-pushed the new-api-http-headers branch from 0f8ea3e to b1e2de2 Compare September 22, 2023 16:07
@codebien codebien force-pushed the new-api-http-headers branch from b1e2de2 to 6d00a46 Compare September 22, 2023 16:08
olegbespalov
olegbespalov approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codebien codebien merged commit e7be89d into main Sep 25, 2023
9 checks passed
@codebien codebien deleted the new-api-http-headers branch September 25, 2023 13:00
@heitortsergent heitortsergent mentioned this pull request Oct 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olegbespalov olegbespalov olegbespalov approved these changes

@mstoykov mstoykov mstoykov approved these changes

Assignees

@codebien codebien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better API for HTTP Headers
3 participants
@codebien @mstoykov @olegbespalov