Implement rate as counter #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
reviewed
Jun 3, 2024
Comment on lines
+184
to
+190
| case metrics.Rate: | ||
| rate, err := o.getOrCreateCounter(name) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| rate.Add(ctx, entry.Value, otelMetric.WithAttributes(MapTagSet(entry.Tags)...)) |
There was a problem hiding this comment.
This should be two counters as you need both the number of occurances and the actual number of possitive or negative values.
I don't know what is the preffered way this likely is good thing to ask around in the community or internally.
Given that this will possibly evolve in the recommended output for k6 it will be nice for it to not have the problems due to which we remove stattsd.
|
Closing in favor of #8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
For the beginning, we do try to treat the
ratemetric as the simple counter, precisely like we do instatsdoutput.Why?
Rate is one of the metrics types of the k6, and it should work.