Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement kubectl helper integration tests #342

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

pablochacin
Copy link
Collaborator

@pablochacin pablochacin commented Sep 12, 2023

Description

Reimplements kubectl package e2e tests using TestContainers and move them to the package as integration tests

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make test) and all tests pass.
  • I have run relevant integration test locally (make integration-xxx for affected packages)
  • I have run e2e test locally
  • Any dependent changes have been merged and published in downstream modules

@pablochacin pablochacin marked this pull request as ready for review September 13, 2023 15:19
@pablochacin pablochacin changed the title Kubectl integration tests Implement kubectl helper integration tests Sep 13, 2023
@pablochacin pablochacin merged commit 8aaeff7 into main Sep 13, 2023
6 checks passed
@pablochacin pablochacin deleted the kubectl-integration-tests branch September 13, 2023 17:10
@codefromthecrypt
Copy link

drive by: just wanted to say I really like what you did. It is concise and readable and balances abstraction well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants