Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metrics registry incompatibility with k6 #846

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

ka3de
Copy link
Collaborator

@ka3de ka3de commented Apr 4, 2023

An incompatibility was detected with k6 after grafana/k6#2999. This commit updates k6 dependency to latest version and fixes the present incompatibility, which mainly affects structures defined in k6 browser tests.

An incompatibility was detected with k6 after grafana/k6#2999.
This commit updates k6 dependency to latest version and fixes the
present incompatibility, which mainly affects structures defined in k6
browser tests.
@ka3de ka3de self-assigned this Apr 4, 2023
@ka3de ka3de requested review from inancgumus and ankur22 April 4, 2023 11:16
Copy link
Member

@inancgumus inancgumus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@ka3de ka3de added the compatibility k6 core compatibility label Apr 4, 2023
@ka3de ka3de added this to the v0.9.0 milestone Apr 4, 2023
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

@ka3de ka3de merged commit 034db5b into main Apr 4, 2023
@ka3de ka3de deleted the fix/k6-registry-compatibility branch April 4, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility k6 core compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants