Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to k6-core master and fix BPool #830

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Update to k6-core master and fix BPool #830

merged 1 commit into from
Mar 16, 2023

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Mar 16, 2023

We detected an incompatibility with k6-core:

  • BPool becomes BufferPool in this PR.

This PR fixes the issue.

@inancgumus inancgumus marked this pull request as ready for review March 16, 2023 08:09
@inancgumus inancgumus requested review from ka3de and ankur22 March 16, 2023 08:09
@inancgumus inancgumus self-assigned this Mar 16, 2023
@inancgumus inancgumus added the compatibility k6 core compatibility label Mar 16, 2023
@inancgumus inancgumus added this to the v0.9.0 milestone Mar 16, 2023
@inancgumus inancgumus force-pushed the fix/bpool branch 2 times, most recently from 441ce9b to 04e483b Compare March 16, 2023 08:27
We detected an incompatibility with k6-core:
(https://github.com/grafana/xk6-browser/actions/runs/4434049483/attempts/2)

- BPool becomes BufferPool in grafana/k6#2879.

This PR fixes the issue.

Co-authored-by: ka3de <[email protected]>
Copy link
Collaborator

@ka3de ka3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inancgumus inancgumus merged commit 6651aa8 into main Mar 16, 2023
@inancgumus inancgumus deleted the fix/bpool branch March 16, 2023 10:30
@inancgumus inancgumus mentioned this pull request Sep 27, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility k6 core compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants