Automatically dismiss dialog boxes #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This handler will listen out for when dialog boxes are opened. When a CDP event is received for a dialog box opening, we will automatically dismiss it. This is the first step in dealing with dialog boxes.
The test dismisses an alert dialogue box.
This test will dismiss a confirm dialog box.
This test will dismiss a prompt type dialog box.
Instead of always checking that the text field is Hello World, when a dialog box opens, it will change the textField to reflect which type of dialog appeared.
A dialog box of type beforeunload seems to only be dismissable if we accept. This is the same solution as what playwright are doing.
Thanks @inancgumus 🙂 I've actioned on all comments. |
This test will ensure that the beforeunload dialog box is accepted when we try to reload the page. Unlike other alert boxes which appear when the page loads, beforeunload boxes appear when the page unloads.
Co-authored-by: İnanç Gümüş <[email protected]>
ankur22
force-pushed
the
feat/655-dismiss-dialog
branch
from
f598949 to
df85e63
Compare
We don't need the struct yet to define each of the tests in the table test. Instead use a slice of string. Resolves: #663 (comment) Co-authored-by: Inanc Gumus <[email protected]>
inancgumus
changed the title
inancgumus
added a commit
that referenced
this pull request
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly closes: #655
We have had a feature request recently as well as seen dialog boxes being used elsewhere. There currently isn't a work around to removing dialog boxes in the path of a test. This change will automatically dismiss the dialog boxes (and accept it for
beforeunloadtype dialogs).