Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor lifecycle tests and add any missing tests #647

Merged
merged 16 commits into from
Nov 30, 2022
Merged

Refactor lifecycle tests and add any missing tests #647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
26a0687
Refactor lifecycle tests ping handler
ankur22 Nov 9, 2022
616400f
Refactor lifecycle test ping.js handler
ankur22 Nov 9, 2022
038e596
Refactor lifecycle tests home handler
ankur22 Nov 9, 2022
9837fa5
Refactor WaitForLoadState lifecycle tests
ankur22 Nov 10, 2022
b5d61b6
Refactor reload lifecycle lifecycle test
ankur22 Nov 10, 2022
a5d283f
Refactor comment WaitForLoadState test
ankur22 Nov 10, 2022
760acfa
Add tests for goto lifecycle events
ankur22 Nov 10, 2022
fa3066c
Add goto lifecycle with subframe tests
ankur22 Nov 10, 2022
2be5854
Refactor the lifecycle tests
ankur22 Nov 10, 2022
e21c08c
Add WaitForNavigation lifecycle tests
ankur22 Nov 10, 2022
40fbc7d
Add a WaitForNavigation timeout test
ankur22 Nov 11, 2022
31365bd
Refactor lifecycle helper method
ankur22 Nov 11, 2022
7f17113
Reformat duration for consistency
ankur22 Nov 11, 2022
6791e5b
Apply suggestions from code review
ankur22 Nov 11, 2022
43956c6
Refactor static lifecycle html file
ankur22 Nov 11, 2022
215000d
Refactor timeout lifecycle test into table test
ankur22 Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading