Export Chromium BrowserType implementation directly
#515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 31, 2022 11:08
The 'v' is redundant, and this way it's consistent with browser.version(), which also doesn't include it.
ankur22
approved these changes
Aug 31, 2022
|
FYI There was a regression introduced by this change, where I'm looking into it and will push a PR shortly. |
imiric
pushed a commit
that referenced
this pull request
Aug 31, 2022
This was a regression introduced by #515, caused by the fact the VU context changes after each iteration[1], so our context initialization needs to happen on each iteration (launch() call) as well. [1]: https://github.com/grafana/k6/blob/e09bb87277865d668586429eee97158fbbfc58e5/js/runner.go#L710
imiric
pushed a commit
that referenced
this pull request
Sep 1, 2022
This was a regression introduced by #515, caused by the fact the VU context changes after each iteration[1], so our context initialization needs to happen on each iteration (launch() call) as well. [1]: https://github.com/grafana/k6/blob/e09bb87277865d668586429eee97158fbbfc58e5/js/runner.go#L710
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #485
This also exposes the xk6-browser version to JS scripts, which is useful for troubleshooting user scripts until grafana/k6#1741 is implemented.