Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor session conn interfaces #269

Merged
merged 5 commits into from
Mar 9, 2022
Merged

Refactor session conn interfaces #269

merged 5 commits into from
Mar 9, 2022

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Mar 9, 2022 •
edited
Loading

Implemented this in response to #268 (comment).

@inancgumus inancgumus requested a review from imiric March 9, 2022 07:51
@inancgumus inancgumus self-assigned this Mar 9, 2022
@inancgumus inancgumus added this to the v0.3.0 milestone Mar 9, 2022
@inancgumus inancgumus mentioned this pull request Mar 9, 2022
Merged
imiric
imiric suggested changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@imiric imiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for changing this 👍

Just spotted a few minor things.

common/execution_context.go Outdated Show resolved Hide resolved
common/connection.go Outdated Show resolved Hide resolved
common/frame_session.go Outdated Show resolved Hide resolved
common/network_manager.go Outdated Show resolved Hide resolved
common/network_manager_test.go Outdated Show resolved Hide resolved
common/screenshotter.go Outdated Show resolved Hide resolved
@inancgumus
Copy link
Member Author

inancgumus commented Mar 9, 2022 •
edited
Loading

Great, thanks for changing this 👍

You're welcome!

Just spotted a few minor things.

See: ec1d3ca

@inancgumus inancgumus requested a review from imiric March 9, 2022 10:55
@inancgumus inancgumus merged commit 1f2ebae into main Mar 9, 2022
@inancgumus inancgumus deleted the refactor/cdp-session-conn branch March 9, 2022 11:24
@inancgumus inancgumus mentioned this pull request Mar 10, 2022
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imiric imiric imiric approved these changes

Assignees

@inancgumus inancgumus

Labels
refactor
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @imiric