Handle panic in screenshoter #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegbespalov
requested review from
mstoykov and
ankur22
and removed request for
a team
olegbespalov
commented
Dec 11, 2024
ankur22
reviewed
Dec 11, 2024
…ort. Fallback to defaults in case of visualViewport is nil
olegbespalov
force-pushed
the
fix/screenshoter
branch
from
3e28115 to
3282dd4
Compare
mstoykov
approved these changes
Dec 11, 2024
olegbespalov
force-pushed
the
fix/screenshoter
branch
from
1672cec to
6fe5428
Compare
mstoykov
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
visualViewporttocssVisualViewport.visualViewportis nil. This is an arguable change since it's partially hiding the issue, on the other side my rational was it's better to make a screenshot with defaults, rather than erroring it. Open to discussion.Why?
Currently, we have an issue with panicing #1502
Checklist
Related PR(s)/Issue(s)
Part of #1502