Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint fixes #1557

Merged
merged 7 commits into from
Dec 11, 2024
Merged

Lint fixes #1557

merged 7 commits into from
Dec 11, 2024

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Dec 10, 2024 •
edited
Loading

What?

Fixes lint errors or ignroes them

Why?

Works towards #1292 so it can be merged into k6

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

@mstoykov mstoykov requested a review from a team as a code owner December 10, 2024 08:58
@mstoykov mstoykov requested review from olegbespalov, joanlopez and ankur22 and removed request for a team December 10, 2024 08:58
olegbespalov
olegbespalov reviewed Dec 10, 2024
View reviewed changes
common/connection.go Show resolved Hide resolved
common/execution_context.go Show resolved Hide resolved
common/remote_object.go Show resolved Hide resolved
k6ext/k6test/vu.go Outdated Show resolved Hide resolved
storage/file_persister.go Show resolved Hide resolved
storage/storage_test.go Show resolved Hide resolved
@mstoykov mstoykov mentioned this pull request Dec 10, 2024
Open
@olegbespalov
Copy link
Contributor

There are also some linter reports, but overall LGTM 👍

@mstoykov
Copy link
Contributor Author

There are also some linter reports, but overall LGTM 👍

Differences in 1.62.2 and 1.60.2 😱

I have been updating k6 golangci-lint upwards so we can just fix a bunch of this at the same time ...

ankur22
ankur22 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found it tiring to follow, i can't imagine how tedious it was to work on 😅 Thank you!

browser/registry_test.go Show resolved Hide resolved
common/execution_context.go Show resolved Hide resolved
common/frame_session.go Outdated Show resolved Hide resolved
common/remote_object.go Show resolved Hide resolved
storage/file_persister.go Show resolved Hide resolved
olegbespalov
olegbespalov approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a resolving the conflict, I'm fine with merging this as it's an anything else fixing separately. It's too big and easily can get new conflicts.

@mstoykov mstoykov merged commit 946e24d into main Dec 11, 2024
23 checks passed
@mstoykov mstoykov deleted the lintFixes branch December 11, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olegbespalov olegbespalov olegbespalov approved these changes

@ankur22 ankur22 ankur22 approved these changes

@joanlopez joanlopez Awaiting requested review from joanlopez joanlopez is a code owner automatically assigned from grafana/k6-core

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mstoykov @olegbespalov @ankur22