Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TestBrowserContextAllOptions #1531

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Add TestBrowserContextAllOptions #1531

merged 1 commit into from
Nov 8, 2024
+72 −0

Conversation

inancgumus
Copy link
Member

What?

Resolves: #1526 (comment)

Why?

We might set incorrect js tag values in BrowserContextOptions.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

@inancgumus inancgumus requested a review from ankur22 November 7, 2024 15:02
@inancgumus inancgumus self-assigned this Nov 7, 2024
@inancgumus inancgumus requested a review from a team as a code owner November 7, 2024 15:02
@inancgumus inancgumus requested review from mstoykov and removed request for a team November 7, 2024 15:02
@inancgumus inancgumus force-pushed the test/parseBrowserContextOptions branch from 03f82f7 to 5854f19 Compare November 7, 2024 15:02
@inancgumus inancgumus force-pushed the test/parseBrowserContextOptions branch from 5854f19 to f449d55 Compare November 8, 2024 15:11
@inancgumus inancgumus requested a review from ankur22 November 8, 2024 15:12
ankur22
ankur22 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@inancgumus inancgumus merged commit 946cb18 into main Nov 8, 2024
23 checks passed
@inancgumus inancgumus deleted the test/parseBrowserContextOptions branch November 8, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 approved these changes

@mstoykov mstoykov Awaiting requested review from mstoykov mstoykov is a code owner automatically assigned from grafana/k6-core

Assignees

@inancgumus inancgumus

Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @ankur22