Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desobekify BrowserContext geolocation #1513

Merged
merged 4 commits into from
Nov 6, 2024
Merged

Desobekify BrowserContext geolocation #1513

merged 4 commits into from
Nov 6, 2024

Conversation

inancgumus
Copy link
Member

What?

  • Desobekify BrowserContext geolocation.
  • Use Sobek translation directly instead of manual parsing.

Why?

See "Desobekifying Sobek transformation" in #1064.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

@inancgumus inancgumus changed the base branch from main to desobekify/browser-context-waitForEvent-options November 5, 2024 21:15
@inancgumus inancgumus force-pushed the desobekify/browser-context-geolocation-options branch from baed93e to d9fec3d Compare November 5, 2024 21:24
ankur22
ankur22 previously approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@inancgumus inancgumus mentioned this pull request Nov 6, 2024
Open
@inancgumus inancgumus marked this pull request as ready for review November 6, 2024 15:48
@inancgumus inancgumus force-pushed the desobekify/browser-context-waitForEvent-options branch from a1619b9 to e582707 Compare November 6, 2024 15:52
Base automatically changed from desobekify/browser-context-waitForEvent-options to main November 6, 2024 15:59
@inancgumus inancgumus dismissed ankur22’s stale review November 6, 2024 15:59

The base branch was changed.

@inancgumus inancgumus force-pushed the desobekify/browser-context-geolocation-options branch from d9fec3d to 505275f Compare November 6, 2024 15:59
@inancgumus inancgumus merged commit 2a7b64b into main Nov 6, 2024
15 of 23 checks passed
@inancgumus inancgumus deleted the desobekify/browser-context-geolocation-options branch November 6, 2024 16:04
@inancgumus inancgumus self-assigned this Nov 7, 2024
@inancgumus inancgumus added stability runtime stability improvements refactor labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 left review comments

Assignees

@inancgumus inancgumus

Labels
refactor stability runtime stability improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @ankur22