Desobekify BrowserContext wait for event options
#1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
changed the base branch from
main
to
desobekify/browser-context-grant-permission-options-parsing
inancgumus
force-pushed
the
desobekify/browser-context-waitForEvent-options
branch
from
738de64 to
efb1ad6
Compare
inancgumus
force-pushed
the
desobekify/browser-context-grant-permission-options-parsing
branch
from
6bcbb03 to
df900b8
Compare
inancgumus
force-pushed
the
desobekify/browser-context-waitForEvent-options
branch
from
efb1ad6 to
1840be2
Compare
inancgumus
force-pushed
the
desobekify/browser-context-grant-permission-options-parsing
branch
from
df900b8 to
998bb01
Compare
inancgumus
force-pushed
the
desobekify/browser-context-waitForEvent-options
branch
2 times, most recently
from
733ab54 to
b112c6f
Compare
inancgumus
force-pushed
the
desobekify/browser-context-grant-permission-options-parsing
branch
from
998bb01 to
74e5505
Compare
inancgumus
force-pushed
the
desobekify/browser-context-waitForEvent-options
branch
2 times, most recently
from
853819b to
a1619b9
Compare
Base automatically changed from
desobekify/browser-context-grant-permission-options-parsing
to
main
November 6, 2024 15:51
inancgumus
force-pushed
the
desobekify/browser-context-waitForEvent-options
branch
from
a1619b9 to
e582707
Compare
inancgumus
deleted the
desobekify/browser-context-waitForEvent-options
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
BrowserContextwaitForEvent Sobek-option parsing into the mapping layer.common.WaitForEventOptionsas it's only used in the mapping.Why?
See "Desobekifying Sobek transformation" in #1064.
Checklist
Related PR(s)/Issue(s)
#1270