Desobekify BrowserContext
option parsing
#1510
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is an experimental PR that is open for discussion.
It moves the Sobek-dependent option parsing part out of the business logic. Once we finish doing the same with the rest of the option parsing, we can entirely remove the Sobek dependency from the business logic.
Why?
We currently parse Sobek values into our business logic types, but the parsing dependency is in an unrelated package (
common
). To enhance maintainability, we move the parsing process and keep related components together (in the mapping layer).Additionally, we could implement a
Validate
method for the business types (in thecommon
package) to check their validity separately from the Sobek transformation. We can do this in a later PR when needed.Checklist
Related PR(s)/Issue(s)
Updates #1064