Refactor promise helpers to fix Interrupt with async code #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
force-pushed
the
fixAsyncInterrupt
branch
from
ef13c50 to
f51aee9
Compare
|
The failure seems to have nothing to do with this PR. it also happens in a scheduled test |
|
just FYI I don't have permissions to merge this, so if do it when you want |
This changes the promise helpers so after grafana/k6#4017 async code and Interrupt will work. AbortingPromises seems to have not been used at all and just adds complexity. And `promises.New()` already does the remaining things needed to happen, so this can be merged even without grafana/k6#4017.
ankur22
force-pushed
the
fixAsyncInterrupt
branch
from
f51aee9 to
b0ecb89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This changes the promise helpers so after grafana/k6#4017 async code and Interrupt will work.
Why?
AbortingPromises seems to have not been used at all and just adds complexity. And
promises.New()already does the remaining things needed to happen, so this can be merged even without grafana/k6#4017.Checklist
Related PR(s)/Issue(s)