-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method field on Match object for page.on('metric')
#1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compares the method from the user vs what the metric was tagged with.
When the incorrect method is used in a Match, the expectation is for the test to continue but not match and therefore the urls aren't tagged with the name and so aren't grouped.
ankur22
force-pushed
the
add/method-page-on-metric
branch
from
October 17, 2024 15:02
9ef4b50
to
a6b12e9
Compare
This was referenced Oct 17, 2024
ankur22
changed the title
Add method on
Add method field on Match object for Oct 17, 2024
page.on('metric')
page.on('metric')
inancgumus
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This change adds a new field to the
Match
object inpage.on('metric')
. It allows the user to add the request method to it so that the tagging can be fine tuned to group requests with the same url and method.method
is an optional field, and if it's not defined then the grouping will be done for all urls that match regardless of the request method.Why?
The use case for this is when requests are made against the same URL but with different request methods. A simple example is a
PUT
to/cart/123
to add an item to the cart, and aGET
to/cart/123
to retrieve the cart.Checklist
Related PR(s)/Issue(s)
Updates: #1450