Refactor to type safe page.on event names
#1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used by all page on event names. With this, we won't require whether a provided event is valid. The compiler will enforce it for us.
This is safe to do so as we will no longer pass a rogue string to this method. Only the page on event names can be passed to this function. Unless, of course, somebody converts a string with an incorrect name to PageOnEventName to call this function. This will easily be catched in reviews, and nobody would do such a thing. We follow the Go idiom of being pragmatic instead of being highly defensive. Also, this method is used by the mapping layer, and there is already an event name check.
inancgumus
force-pushed
the
refactor/type-safe-page-on-event-names
branch
from
7573397 to
1573c7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add and use
PageOnEventName.Why?
For greater readability, clarity, and type safety at the compile time.
Checklist
Related PR(s)/Issue(s)
Updates: #1227