Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remote file upload v2 #1419

Merged
merged 10 commits into from
Sep 11, 2024
Merged

Add remote file upload v2 #1419

merged 10 commits into from
Sep 11, 2024

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Sep 9, 2024 •
edited
Loading

What?

Update to the new remote file upload protocol.

Why?

  • Support the generic file upload protocol.
  • Ability to limit files to the total file size per VUhs used.
  • Provide better control and ability to limit total screenshot size.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

  • grafana/k6-cloud#2539
  • grafana/k6-cloud#2034

@inancgumus inancgumus added the remote remote browser related label Sep 9, 2024
@inancgumus inancgumus self-assigned this Sep 9, 2024
@inancgumus inancgumus force-pushed the add/screenshot-upload-v2 branch 4 times, most recently from 4469a23 to 78c461b Compare September 10, 2024 15:53
inancgumus
inancgumus commented Sep 10, 2024
View reviewed changes
Copy link
Member Author

@inancgumus inancgumus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some information.

@inancgumus inancgumus force-pushed the add/screenshot-upload-v2 branch 6 times, most recently from 6acbbc5 to 63a303b Compare September 10, 2024 19:10
@inancgumus inancgumus marked this pull request as ready for review September 10, 2024 19:10
@inancgumus inancgumus requested a review from ankur22 September 10, 2024 19:10
@inancgumus inancgumus force-pushed the add/screenshot-upload-v2 branch from 63a303b to fcb6d5c Compare September 10, 2024 19:29
ankur22
ankur22 approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! LGTM 🚀

@inancgumus inancgumus force-pushed the add/screenshot-upload-v2 branch from fcb6d5c to 827263c Compare September 11, 2024 15:01
@inancgumus inancgumus merged commit dd61af6 into main Sep 11, 2024
22 checks passed
@inancgumus inancgumus deleted the add/screenshot-upload-v2 branch September 11, 2024 15:08
@BrewTestBot BrewTestBot mentioned this pull request Sep 30, 2024
Merged
@inancgumus inancgumus mentioned this pull request Oct 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 approved these changes

Assignees

@inancgumus inancgumus

Labels
remote remote browser related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @ankur22