Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setChecked #1403

Merged
merged 9 commits into from
Aug 14, 2024
Merged

Add setChecked #1403

merged 9 commits into from
Aug 14, 2024

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Aug 6, 2024

What?

Please see #1340.

Why?

Please see #1340.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

Updates #1340
Closes #354
Closes #368

@inancgumus inancgumus self-assigned this Aug 6, 2024
@inancgumus inancgumus marked this pull request as ready for review August 6, 2024 17:19
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

common/frame.go Show resolved Hide resolved
@inancgumus inancgumus merged commit e8c6748 into main Aug 14, 2024
23 checks passed
@inancgumus inancgumus deleted the feat/set-checked branch August 14, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SetChecked support to Page and Frame locator.setChecked(checked[, options])
2 participants