Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix request and response headerValue #1376

Merged
merged 4 commits into from
Jun 7, 2024
Merged

Fix request and response headerValue #1376

merged 4 commits into from
Jun 7, 2024

Conversation

ankur22
Copy link
Collaborator

@ankur22 ankur22 commented Jun 7, 2024 •
edited
Loading

What?

Fix request.headerValue and response.headerValue to be case insensitive.

Why?

It's easier to use this way and matches PW.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

@ankur22 ankur22 requested a review from inancgumus June 7, 2024 11:08
@ankur22 ankur22 changed the base branch from main to main-async June 7, 2024 11:08
Base automatically changed from main-async to main June 7, 2024 12:17
@ankur22 ankur22 force-pushed the fix/headerValue branch from cb806b9 to 34c4aa0 Compare June 7, 2024 13:46
inancgumus
inancgumus approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@inancgumus inancgumus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement for compatibility 👍

@ankur22 ankur22 merged commit 7cee372 into main Jun 7, 2024
23 checks passed
@ankur22 ankur22 deleted the fix/headerValue branch June 7, 2024 13:54
@inancgumus inancgumus added the playwright Issue relating to Playwright compatibility label Jun 7, 2024
@BrewTestBot BrewTestBot mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inancgumus inancgumus inancgumus approved these changes

Assignees

@ankur22 ankur22

Labels
playwright Issue relating to Playwright compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankur22 @inancgumus