Async JSHandle prepare
#1365
Merged
Async JSHandle prepare
#1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
force-pushed
the
async/js-handle-prepare
branch
2 times, most recently
from
0b09ecb to
3523f93
Compare
inancgumus
added
stability
inancgumus
force-pushed
the
async/response
branch
2 times, most recently
from
72377f7 to
1982d55
Compare
inancgumus
force-pushed
the
async/js-handle-prepare
branch
from
3523f93 to
76fa23c
Compare
ankur22
approved these changes
Jun 4, 2024
common/frame_manager.go
Outdated
| for _, child := range frame.ChildFrames() { | ||
| m.logger.Debugf("FrameManager:removeFramesRecursively", | ||
| "fmid:%d cfid:%v pfid:%v cfname:%s cfurl:%s", | ||
| m.ID(), child.ID(), frame.ID(), child.Name(), child.URL()) | ||
|
|
||
| m.removeFramesRecursively(child) | ||
| if err := m.removeFramesRecursively(child); err != nil { | ||
| return fmt.Errorf("removing child frames recursively: %w", err) |
There was a problem hiding this comment.
Does this clash with the error in removeChildFramesRecursively? It might make debugging difficult. Could this error instead be changed to removing frames recursively?
Then there's the error below when calling frame.detach, which i think could change to detaching frame.
WDYT?
There was a problem hiding this comment.
Yep, fixed in 736e87e.
inancgumus
force-pushed
the
async/js-handle-prepare
branch
from
76fa23c to
736e87e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Prepare
JSHandleto be async by turning panics into errors.Why?
JSHandleto async.Checklist
Related PR(s)/Issue(s)
#1303