Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k6-core compatibility: Fix Group and Tag usage #1357

Merged
merged 2 commits into from
May 29, 2024
Merged

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented May 29, 2024

What?

Updates Group usage in k6ext.NewVU to the latest k6.

Why?

We can't run integration tests with the latest k6 master: Group has been removed from State.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

grafana/k6#2869

@inancgumus inancgumus self-assigned this May 29, 2024
@inancgumus inancgumus added compatibility k6 core compatibility tests labels May 29, 2024
@inancgumus inancgumus marked this pull request as ready for review May 29, 2024 10:36
@inancgumus
Copy link
Member Author

@mstoykov Merging this for now. Please let us know if we're doing something naively wrong here, and we can send another PR.

@inancgumus inancgumus merged commit d7a1b91 into main May 29, 2024
17 checks passed
@inancgumus inancgumus deleted the update/k6-master branch May 29, 2024 11:55
@inancgumus inancgumus changed the title Update to k6 v0.51.1-0.20240529085517-bdbe5b52d1f5 Fix Group and Tag usage due to k6-core update May 29, 2024
@inancgumus inancgumus changed the title Fix Group and Tag usage due to k6-core update k6-core compatibility: Fix Group and Tag usage Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility k6 core compatibility tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants