Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare Page for async migration part #3 #1352

Merged
merged 17 commits into from
May 29, 2024
Merged

Prepare Page for async migration part #3 #1352

merged 17 commits into from
May 29, 2024

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented May 27, 2024 •
edited
Loading

What?

Turns panics into errors only for Page's final set of methods.

Why?

To make the async migration more reliable.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

#1307

@inancgumus inancgumus added refactor mapping k6 browser to Goja mapping related. stability runtime stability improvements labels May 27, 2024
@inancgumus inancgumus self-assigned this May 27, 2024
@inancgumus inancgumus mentioned this pull request May 27, 2024
Closed
@inancgumus inancgumus force-pushed the async/page-prepare-part3 branch 2 times, most recently from aa8343d to f846d3b Compare May 27, 2024 13:47
@inancgumus inancgumus marked this pull request as ready for review May 27, 2024 14:15
@inancgumus inancgumus requested a review from ankur22 May 27, 2024 14:15
@inancgumus inancgumus force-pushed the async/page-prepare-part2 branch from 944e00b to ab24cee Compare May 28, 2024 10:13
@inancgumus inancgumus force-pushed the async/page-prepare-part3 branch from f846d3b to 9f75f57 Compare May 28, 2024 10:13
@inancgumus inancgumus force-pushed the async/page-prepare-part2 branch from ab24cee to 1181a75 Compare May 28, 2024 11:05
@inancgumus inancgumus force-pushed the async/page-prepare-part3 branch from 9f75f57 to d733e4d Compare May 28, 2024 11:06
ankur22
ankur22 approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Base automatically changed from async/page-prepare-part2 to main-async May 29, 2024 10:00
inancgumus added 15 commits May 29, 2024 13:01
@inancgumus inancgumus force-pushed the async/page-prepare-part3 branch from d733e4d to 80bf1cb Compare May 29, 2024 10:01
@inancgumus inancgumus merged commit 3c80c82 into main-async May 29, 2024
12 of 14 checks passed
@inancgumus inancgumus deleted the async/page-prepare-part3 branch May 29, 2024 10:01
@BrewTestBot BrewTestBot mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 approved these changes

Assignees

@inancgumus inancgumus

Labels
mapping k6 browser to Goja mapping related. refactor stability runtime stability improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @ankur22