Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare Locator for async migration #1330

Merged
merged 25 commits into from
May 16, 2024
Merged

Prepare Locator for async migration #1330

merged 25 commits into from
May 16, 2024

Conversation

inancgumus
Copy link
Member

What?

Turns panics into errors.

Why?

To make the async migration more reliable.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

#1305

@inancgumus inancgumus self-assigned this May 13, 2024
@inancgumus inancgumus added mapping k6 browser to Goja mapping related. refactor stability runtime stability improvements labels May 13, 2024
@inancgumus inancgumus mentioned this pull request May 13, 2024
Closed
@inancgumus inancgumus force-pushed the async/browsercontext branch from bf7afad to 9c872c9 Compare May 13, 2024 13:39
Base automatically changed from async/browsercontext to main-async May 13, 2024 13:42
@inancgumus inancgumus force-pushed the async/locator-prepare branch from f524f45 to bc9daca Compare May 13, 2024 13:47
inancgumus added 2 commits May 14, 2024 11:40
@inancgumus
Refactor Locator tests to return err
84d64e9
@inancgumus
Fix tap mapping tests
668c3bb 
These definitions are about the concrete type, not the mapping. So they
should not return a promise.
@inancgumus inancgumus marked this pull request as ready for review May 14, 2024 08:50
@inancgumus inancgumus requested a review from ankur22 May 14, 2024 08:50
ankur22
ankur22 approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/locator_test.go Outdated Show resolved Hide resolved
tests/locator_test.go Show resolved Hide resolved
@inancgumus inancgumus merged commit 5611f2b into main-async May 16, 2024
14 checks passed
@inancgumus inancgumus deleted the async/locator-prepare branch May 16, 2024 09:48
@BrewTestBot BrewTestBot mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 approved these changes

Assignees

@inancgumus inancgumus

Labels
mapping k6 browser to Goja mapping related. refactor stability runtime stability improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @ankur22