Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare BrowserContext for async migration #1327

Merged
merged 8 commits into from
May 13, 2024
Merged

Prepare BrowserContext for async migration #1327

merged 8 commits into from
May 13, 2024

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented May 10, 2024 •
edited
Loading

What?

Turns panics into errors.

Why?

To make the async migration more reliable.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

#1295

@inancgumus inancgumus added refactor mapping k6 browser to Goja mapping related. stability runtime stability improvements labels May 10, 2024
@inancgumus inancgumus self-assigned this May 10, 2024
@inancgumus inancgumus force-pushed the async/browsercontext-prepare branch from be1cbb6 to c087730 Compare May 10, 2024 08:20
@inancgumus inancgumus marked this pull request as ready for review May 10, 2024 08:21
@inancgumus inancgumus requested a review from ankur22 May 10, 2024 08:21
@inancgumus inancgumus mentioned this pull request May 10, 2024
Closed
Base automatically changed from fix/context-mappings to main-async May 13, 2024 09:26
@inancgumus inancgumus requested review from ankur22 and removed request for ankur22 May 13, 2024 11:26
ankur22
ankur22 approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inancgumus inancgumus merged commit 0d66ab4 into main-async May 13, 2024
14 checks passed
@inancgumus inancgumus deleted the async/browsercontext-prepare branch May 13, 2024 13:37
@BrewTestBot BrewTestBot mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatheusLemes5 MatheusLemes5 MatheusLemes5 approved these changes

@ankur22 ankur22 ankur22 approved these changes

Assignees

@inancgumus inancgumus

Labels
mapping k6 browser to Goja mapping related. refactor stability runtime stability improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inancgumus @ankur22 @MatheusLemes5