Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async Keyboard #1314

Merged
merged 2 commits into from
May 8, 2024
Merged

Async Keyboard #1314

merged 2 commits into from
May 8, 2024

Conversation

inancgumus
Copy link
Member

What?

See #1304

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

@inancgumus inancgumus added the async supports async (promises) label May 8, 2024
@inancgumus inancgumus self-assigned this May 8, 2024
@inancgumus inancgumus mentioned this pull request May 8, 2024
Closed
@inancgumus inancgumus marked this pull request as ready for review May 8, 2024 10:07
@inancgumus inancgumus requested a review from ankur22 May 8, 2024 10:07
ankur22
ankur22 approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

examples/keyboard.js Show resolved Hide resolved
@inancgumus inancgumus force-pushed the async/keyboard-prepare branch from ce59afd to 5132a18 Compare May 8, 2024 10:29
Base automatically changed from async/keyboard-prepare to main-async May 8, 2024 10:43
inancgumus added 2 commits May 8, 2024 13:43
@inancgumus
Async keyboard
6fb481b
@inancgumus
Update keyboard JS examples for async
92dd073 
Also fixes a race condition by adding waitForNavigation.
@inancgumus inancgumus merged commit 099a6a4 into main-async May 8, 2024
14 checks passed
@inancgumus inancgumus deleted the async/keyboard branch May 8, 2024 11:38
@BrewTestBot BrewTestBot mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 approved these changes

Assignees

@inancgumus inancgumus

Labels
async supports async (promises)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @ankur22