Fix NPD when using goto on a second page #1301
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This fixes an issue when working with a second tab (i.e. opening a new page in the same existing browserContext), and navigating to a url.
You can also test with the following test script to see what happens without the fix and with the fix:
Why?
This issue would arise as soon as any API is used from the new page instance. This was occurring due to the unmapped
browserContext
when getting it from thebrowser
.Checklist
Related PR(s)/Issue(s)