Remove unimplemented apis

[ankur22]

What?

Removing the unimplemented API function bodies.

Why?

It's confusing when auditing APIs to have some that do not have any implementation. It's as if they are a priority, which is not the case. We will add the APIs that we think we need and when the community asks for them.

Checklist

• I have performed a self-review of my code
• I have added tests for my changes
• I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

[allansson]

I've built and run the extension and it works normally.

It's hard to test that something isn't there, but looking at the code I don't see any methods removed that have an implementation and there would definitely be a build error if some reference was left.

I did however find three other methods that don't have an implementation:

• xk6-browser/common/browser_context.go

  Line 261 in a53651b

  return fmt.Errorf("BrowserContext.setExtraHTTPHeaders(headers) has not been implemented yet: %w", k6error.ErrFatal)

• xk6-browser/chromium/browser_type.go

  Line 220 in a53651b

  k6common.Throw(rt, errors.New("BrowserType.LaunchPersistentContext(userDataDir, opts) has not been implemented yet"))

• xk6-browser/common/page.go

  Line 820 in a53651b

  k6ext.Panic(p.ctx, "Page.goBack(opts) has not been implemented yet")

I'm not sure if there's a reason why these should remain, but I just wanted to point it out.

[inancgumus]

👍

setExtraHTTPHeaders and LaunchPersistentContext

It seems safe to remove these ones.

goBack

@ankur22 probably hasn't removed goBack because this test requires it. However, we can easily implement an undocumented method that panics (since the test requires "a method" (like GoBack) that panics). And then we can remove GoBack.

[ankur22]

setExtraHTTPHeaders and LaunchPersistentContext

Yep, good spot, I've removed them in 4a2e584.

goBack

As @inancgumus mentioned it was indeed due to the goback method, but I've removed that now and changed the test in f9d2190 to still behave in the same way (apart from creating the browserContext and page first).

[allansson]

👍