Remove logging in-flight requests #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We noticed that we shouldn't find an internally failed request as it can cause data race issues within the internal components of the module. Also, we've decided that logging in-flight requests only adds noise without bringing any tangingle value. We keep logging the failed request, though. ...
This was referenced Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Remove logging in-flight requests when a request is failed.
Why?
We noticed we shouldn't look up an internally failed request, as it can cause race condition issues within the module's internals. Also, we've decided that logging in-flight requests only adds noise without bringing any tangential value.
We keep logging the failed request, though.
Checklist
Related PR(s)/Issue(s)
Updated #986