Refactor k6 object and add testRunID #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur22
force-pushed
the
refactor/k6-object-mapping
branch
2 times, most recently
from
6d15f8a to
f7b0ebb
Compare
This helps it be explicit and easier to spot instead of it being hidden within the creation of a new browser context.
This is now being performed in newPage which is more explicit, whereas the previous approach (which is being removed) was too implicit and not extendable.
This will allow callers to pass the NewVU opts, e.g. to set env vars.
ankur22
force-pushed
the
refactor/k6-object-mapping
branch
from
f7b0ebb to
bb73a1f
Compare
ankur22
force-pushed
the
refactor/k6-object-mapping
branch
from
bb73a1f to
6652248
Compare
We can now add the testRunId to the k6 object which is injected into the page, allowing external apps to work with the k6 object, while also allowing them to link back to the test run id.
ankur22
force-pushed
the
refactor/k6-object-mapping
branch
from
6652248 to
dd33903
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The first few commits refactor how the
k6object is assigned to thewindowobject. Instead of it being done implicitly in theNewBrowserContextconstructor, it is now done in the mapping layer after a newbrowserContexthas been created, which is whenbrowser.newPageandbrowser.newContextare called.The last commit adds a new field in the
k6object which istestRunId.Why?
k6object towindow.testRunIdtok6which enables external apps (such as Faro) to link back to the test run.Checklist
Related PR(s)/Issue(s)
https://github.com/grafana/k6-cloud/issues/2066