-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Goja from Execution Context Eval and from related parts #1189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like a pretty big step forward into moving away from working with goja within the core business logic 👏
I've left comments for you to review, but I need to review it some more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. The code is easier to read without all that goja
back-and-forth type transformation.
We needed to everything in this PR in one Go for the code to compile.
Co-authored-by: Ankur Agarwal <[email protected]>
Co-authored-by: Ankur Agarwal <[email protected]>
Co-authored-by: Ankur Agarwal <[email protected]>
This commit is intentionally failing
00b7f9f
to
b34470e
Compare
These should be fixed.
b34470e
to
3ed072b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
What?
All of these changes are forced by the compiler and tests while working on
ExecutionContext.Eval
.ExecutionContext
. After this refactoring, everything started to fall apart, and we needed to refactor many parts of the code together. I couldn't split the second commit into smaller commits because it would break the build.common
types.convert
helper to convertany
values to type-safe values. There is another one in the test browser as a helper for the tests.Note
These additional PRs are created that will merge into this one.
Why?
Checklist
Related PR(s)/Issue(s)
Updates: #1182, #1170